fix: Windows compatibility for hindsight-embed#867
Merged
nicoloboschi merged 1 commit intovectorize-io:mainfrom Apr 7, 2026
Merged
Conversation
Contributor
beordie
commented
Apr 4, 2026
beordie
commented
- Add cross-platform file locking support
- Use fcntl on Unix-like systems, msvcrt on Windows
- Add detailed documentation explaining why we don't use external libraries
- Add cross-platform file locking support - Use fcntl on Unix-like systems, msvcrt on Windows - Add detailed documentation explaining why we don't use external libraries - Fixes issue where module couldn't be imported on Windows due to missing fcntl
beordie
force-pushed
the
fix/windows-compatibility-hindsight-embed
branch
from
6f99238 to
593c04e
Compare
This was referenced Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.